fix(cli): increase size of blocking task threadpool on windows #26465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26179.
The original error reported in that issue is fixed on canary, but in local testing on my windows machine,
next build
would just hang forever.After some digging, what happens is that at some point in next build, readFile promises (from
fs/promises
) just never resolve, and so next hangs.It turns out the issue is saturating tokio's blocking task thread pool. We previously limited the number of blocking threads to 32, and at some point those threads are all in use and there's no thread available for the file reads.
What's taking up all of those threads? The answer turns out to be
tokio::process
. On windows, child process stdio uses the blocking threadpool: tokio-rs/tokio#4824. When you poll the child's stdio on windows, it spawns a blocking task per poll, and callsstd::io::Read::read
in the blocking context. That call can block until data is available.Putting it all together, what happens is that Next.js spawns
2 * the number of CPU cores
deno child subprocesses to do work. We implementchild_process
withtokio::process
. When the child processes' stdio get polled, blocking tasks get spawned, and those blocking tasks might block until data is available. So if you have 16 cores (as I do), there are going to be potentially >32 blocking task threadpool threads taken just by the child processes. That leaves no room for other tasks to make progressTo fix this, for now, increase the size of the blocking threadpool on windows. 4 * the number of CPU cores should be enough to leave room for other tasks to make progress.
Longer term, this can be fixed more properly when we handroll our own subprocess code (needed for detached processes and additional pipes on windows).