Skip to content

feat(lsp): "typescript.preferences.preferTypeOnlyAutoImports" setting #26546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nayeemrmn
Copy link
Contributor

Closes denoland/vscode_deno#1197.

This reverts the hack implemented in #25662. It turns out there is a setting for this.

Note: this behaviour would no longer be enabled by default. Users relying on it should add "typescript.preferences.preferTypeOnlyAutoImports": true to their editor settings. cc @lucacasonato @marvinhagemeister

Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit 38c7af4 into denoland:main Oct 25, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-prefer-type-only-auto-imports branch October 25, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno not respecting preferTypeOnlyAutoImports: false
2 participants