Skip to content

fix(node:zlib): gzip & gzipSync should accept ArrayBuffer #26762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix(node:zlib): gzip & gzipSync should accept ArrayBuffer #26762

merged 1 commit into from
Nov 6, 2024

Conversation

satyarohith
Copy link
Member

Closes #26638

@satyarohith satyarohith enabled auto-merge (squash) November 6, 2024 14:01
bartlomieju
bartlomieju approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satyarohith satyarohith merged commit b3a3d84 into denoland:main Nov 6, 2024
17 checks passed
@satyarohith satyarohith deleted the fix_26638 branch November 6, 2024 14:31
littledivy pushed a commit that referenced this pull request Nov 10, 2024
@satyarohith @littledivy
fix(node:zlib): gzip & gzipSync should accept ArrayBuffer (#26762)
faed1d8 
Closes #26638
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@littledivy littledivy Awaiting requested review from littledivy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[node-compat] zlib.gzip() does not accept ArrayBuffer
2 participants
@satyarohith @bartlomieju