Skip to content

fix(ext/websocket): initialize error attribute of WebSocket ErrorEvent #26796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

littledivy
Copy link
Member

Fixes #26216

Not required by the spec but Discord.js depends on it, see #26216 (comment)

Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be closed considering #26216 (comment)?

@littledivy
Copy link
Member Author

This PR fixes it on older versions of Discord.js

@littledivy littledivy merged commit 3b99f68 into denoland:main Nov 12, 2024
17 checks passed
@littledivy littledivy deleted the websocket_errorevent_error branch November 12, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when Network Connection Fails in discord.js on Deno
2 participants