Skip to content

fix(ext/node): update node version in process object #27044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 23, 2025

Conversation

SebastienGllmt
Copy link
Contributor

The process polyfill hardcodes the latest stable node version. On October 29th, nodejs announced that v22.11.0 is the new stable version (with v20 moving into maintenance LTS)

To reflect this, I've bumped the hardcoded version in the process polyfill

For reference, you can see the latest time this hardcoded value was updated here: #22709

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2024

CLA assistant check
All committers have signed the CLA.

@dsherret dsherret requested a review from kt3k April 15, 2025 21:39
@dsherret dsherret changed the title chore: update hardcoded stable node verson in process polyfill fix: update hardcoded stable node verson in process polyfill Apr 15, 2025
@kt3k
Copy link
Member

kt3k commented Apr 22, 2025

Updated the headers/node.lib files for v22

ref #26749

@kt3k
Copy link
Member

kt3k commented Apr 22, 2025

@nathanwhit Do you remember how you created node.lib.tar.gz in #26749 ?

@kt3k kt3k changed the title fix: update hardcoded stable node verson in process polyfill fix(ext/node): update node version in process object Apr 23, 2025
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 40c5dff into denoland:main Apr 23, 2025
18 checks passed
@kt3k
Copy link
Member

kt3k commented Apr 23, 2025

Landing for now as the contents of header/lib files shouldn't be very important in those test cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants