feat(otel): span context propagators #28460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowlKats
changed the title
| @@ -0,0 +1,295 @@ | |||
| { | |||
There was a problem hiding this comment.
Because of DENO_UNSTABLE_OTEL_DETERMINISTIC, there are now multiple span ids named 0000000000000001 here - that's not good.
We need to update DENO_UNSTABLE_OTEL_DETERMINISTIC to take a prefix to use for span IDs, so that different processes generate different (sequential) span IDs. I'll push a fix for this shortly.
ry
pushed a commit
that referenced
this pull request
Mar 14, 2025
Co-authored-by: Luca Casonato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27919
TODO: add opentelemetry-js copyright