Skip to content

fix(check): support typesVersions in npm dependencies #28468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Mar 11, 2025

}
} else {
false
};
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not exactly correct, but it should cover 99.9% of cases.

Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 348900b into denoland:main Mar 11, 2025
18 checks passed
@dsherret dsherret deleted the fix_support_types_versions branch March 11, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect types@ exports condition or typesVersions
2 participants