fix(ext/node): correct STATUS_CODES strings
#28489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches Node.js `http.STATUS_CODES` values now. Deno is currently exporting an enum directly, which 1) adds keys like `BadRequest` and 2) ships the status-text strings as non-space-delimited values (eg, `'BadRequest`` instead of `'Bad Request'`) Signed-off-by: Luke Edwards <[email protected]>
ry
pushed a commit
that referenced
this pull request
Mar 14, 2025
Matches Node.js `http.STATUS_CODES` values now. Deno is currently exporting an enum directly, which 1) adds keys like `BadRequest` and 2) ships the status-text strings as non-space-delimited values (eg, `'BadRequest`` instead of `'Bad Request'`) Signed-off-by: Luke Edwards <[email protected]>
ry
pushed a commit
that referenced
this pull request
Apr 7, 2025
Matches Node.js `http.STATUS_CODES` values now. Deno is currently exporting an enum directly, which 1) adds keys like `BadRequest` and 2) ships the status-text strings as non-space-delimited values (eg, `'BadRequest`` instead of `'Bad Request'`) Signed-off-by: Luke Edwards <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches Node.js
http.STATUS_CODESvalues now. Deno is currently exporting an enum directly, which 1) adds keys likeBadRequestand 2) ships the status-text strings as non-space-delimited values (eg,'BadRequest`` instead of'Bad Request'`)Current
deno repl -Asnapshot: