Skip to content

feat(cli): deno check maps to deno check . #28655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Mar 28, 2025

This PR implements the suggestion given in the comment #28455 (comment)

Now deno check without arguments maps to deno check .

@kt3k kt3k added this to the 2.3.0 milestone Mar 28, 2025
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua
Copy link
Contributor

iuioiua commented Apr 15, 2025

Perhaps this should be regarded as a fix as it's currently blocking Fresh CI. See denoland/fresh#2852.

@kt3k
Copy link
Member Author

kt3k commented Apr 15, 2025

I suppose this doesn't change deno lint or deno fmt behaviors..

@dsherret dsherret merged commit e0fc1e1 into denoland:main Apr 15, 2025
18 checks passed
@kt3k kt3k deleted the feat-cli-deno-check-no-arg branch April 16, 2025 09:24
marvinhagemeister pushed a commit to denoland/fresh that referenced this pull request Apr 22, 2025
…#2852)

~~This fixes CI for current PRs until
denoland/deno#28655 is added to Deno 2.3.0.~~

This fixes CI until denoland/deno#28923 is
fixed. Then, we can use `Deno.makeTempDir()` and not have to use
`tmp_*/`.
@gewoonwoutje
Copy link
Contributor

Closed duplicate #27942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants