fix(install): read extra package info from node_modules and fallback to registry #28893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (2)
- tests/registry/npm/@denotest/extra-info/1.0.0/package.json: Language not supported
- tests/specs/install/package_extra_nmd/test.jsonc: Language not supported
nathanwhit
commented
Apr 14, 2025
nathanwhit
added a commit
that referenced
this pull request
Apr 14, 2025
…to registry (#28893) Fixes #28891 We were checking if the node_modules entry for the package was present, but then reading from the global cache. Instead, read from the package.json in node_modules. As a fallback(which in theory should only really happen if the node_modules dir is somehow messed up), take the more expensive (but likely to work) path of reading from the registry.json.
nathanwhit
added a commit
that referenced
this pull request
Apr 14, 2025
…to registry (#28893) Fixes #28891 We were checking if the node_modules entry for the package was present, but then reading from the global cache. Instead, read from the package.json in node_modules. As a fallback(which in theory should only really happen if the node_modules dir is somehow messed up), take the more expensive (but likely to work) path of reading from the registry.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28891
We were checking if the node_modules entry for the package was present, but then reading from the global cache.
Instead, read from the package.json in node_modules. As a fallback(which in theory should only really happen if the node_modules dir is somehow messed up), take the more expensive (but likely to work) path of reading from the registry.json.