feat(compile): support for ffi and node native addons #28934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
changed the title
dsherret
commented
Apr 16, 2025
| @@ -87,6 +87,7 @@ impl CliCjsCodeAnalyzer { | |||
| source: &str, | |||
| esm_analysis_mode: EsmAnalysisMode, | |||
| ) -> Result<CliCjsAnalysis, JsErrorBox> { | |||
| let source = source.strip_prefix('\u{FEFF}').unwrap_or(source); // strip BOM | |||
There was a problem hiding this comment.
Ran into this while testing.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for FFI and Node native addons by extracting shared libraries and .node modules to a temporary file, introducing new runtime options and helper functionality.
- Introduces a new option (deno_rt_native_addon_loader) to various worker service options.
- Updates initialization calls for deno_ffi and deno_napi extensions to pass native addon loader parameters.
- Adds a new helper library (denort_helper) for native addon loading and associated error handling.
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| runtime/worker.rs | Added new option and updated extension initialization. |
| runtime/web_worker.rs | Added native addon loader option to web worker service options. |
| runtime/snapshot_info.rs & snapshot.rs | Updated snapshot extension initialization calls. |
| runtime/examples/extension/main.rs | Example now provides a native addon loader parameter. |
| ext/rt_helper/* | Introduced new helper library for native addon loading. |
| ext/napi/* and ext/ffi/* | Updated modules to pass and use the new native addon loader option. |
| cli/* | Updated CLI components and Cargo.toml for addon loader support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts out the shared libraries and
.nodenative modules to a temp file and opens them from there. This means that this implementation will not work in every scenario. For example, a library could require other files that only exist in the in-memory file system. To solve that, we'll introduce #28918 later or adapt this solution to solve more issues.Additionally, this will not work when run on readonly file systems.
Closes #23266