Skip to content

feat: code sign deno.exe #28963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 25, 2025
Merged

feat: code sign deno.exe #28963

merged 7 commits into from
Apr 25, 2025

Conversation

piscisaureus
Copy link
Member

@piscisaureus piscisaureus commented Apr 18, 2025

@piscisaureus piscisaureus force-pushed the exe-codesign branch 2 times, most recently from 70caad4 to 3923936 Compare April 18, 2025 21:44
@bartlomieju bartlomieju merged commit 90e90cd into main Apr 25, 2025
18 checks passed
@bartlomieju bartlomieju deleted the exe-codesign branch April 25, 2025 06:27
@csvn
Copy link
Contributor

csvn commented Apr 30, 2025

Will this change to sign the .exe file on Windows effectively mean that I will no longer get Windows Defender blocking the deno.exe file during/after deno upgrade sometimes? If so, this change is great!

@bartlomieju
Copy link
Member

@csvn yes, that should be the result

@csvn
Copy link
Contributor

csvn commented Apr 30, 2025

Awesome, I've had issues similar to #5301 and #16886 occasionally, most often resolved by retrying as admin or reinstalling from scratch. Excellent work @piscisaureus & @bartlomieju (and team)! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants