Skip to content

feat(node API): add fs.glob, fs.globSync, fs.promises.glob #28972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

jeff-hykin
Copy link

@jeff-hykin jeff-hykin commented Apr 19, 2025

(pinging @crowlKats cause you know who I am and vaguely know the quality / lack-of-quality to expect from me)

  • Good News Items:

  • Bad News (for you guys):

    • I'm not going to spend anymore time on this PR; I fought with cargo for 3 hours trying to get it to build deno, and that's all the time I can afford. Hopefully, using this as a starting point will save someone on the Deno team some time
    • Its not formatted
    • I didn't write any tests for it
    • There's no way the types are going to pass a linter check
    • I needed to polyfill two primordials that I belive are not available in deno: ArrayPrototypeFromAsync and ArrayPrototypeFlatMap. They're tested, but you might prefer to create the actual primordial versions instead of having a polyfill in the codebase.

@jeff-hykin jeff-hykin changed the title feat(node API): WIP, add fs.glob, fs.globSync, fs.promises.glob feat(node API): add fs.glob, fs.globSync, fs.promises.glob Apr 20, 2025
@kt3k kt3k mentioned this pull request May 18, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants