Skip to content

fix(coverage): improve responsiveness of HTML reporter on small screens #28993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

fix(coverage): improve responsiveness of HTML reporter on small screens #28993

merged 1 commit into from
Apr 22, 2025

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Apr 22, 2025 •
edited
Loading

Excuse the oversized screenshots. They were taken when scrolled to the right on a small screen. @kt3k

Before (all files view)

_Users_asher_GitHub_redis_coverage_html_index html(iPhone SE) (1)

After (all files view)

_Users_asher_GitHub_redis_coverage_html_index html(iPhone SE) (2)

Before (file view)

_Users_asher_GitHub_redis_coverage_html_mod ts html(iPhone SE)

After (file view)

_Users_asher_GitHub_redis_coverage_html_mod ts html(iPhone SE) (1)

@iuioiua iuioiua marked this pull request as ready for review April 22, 2025 02:08
@kt3k kt3k self-requested a review April 22, 2025 03:03
kt3k
kt3k approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with the html coverage report of std.

This PR makes the scrolling part of the overflowed page reasonable on mobile screen.

LGTM

@kt3k kt3k merged commit 66185e0 into denoland:main Apr 22, 2025
22 checks passed
@iuioiua iuioiua deleted the coverage-html-overflow branch April 22, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k