Skip to content

fix(vendor): strip jsr version meta module graph data #29120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Apr 30, 2025

Test is in:

This removes the moduleGraphX data from the <version>_meta.json files for jsr packages when copying from the global cache to the local one. This property is not really useful to vendor because it's just a performance optimization when downloading the files and someone may be changing the data in the files leading to the moduleGraph data to be out of date.

Closes #28427 (I don't believe there's anything else we could or should strip)

@dsherret dsherret requested a review from nathanwhit April 30, 2025 21:59
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret enabled auto-merge (squash) April 30, 2025 22:04
@dsherret dsherret merged commit 2bc8b9b into denoland:main May 1, 2025
18 checks passed
@dsherret dsherret deleted the fix_remove_module_graph_jsr_version_metadata_vendor branch May 1, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSR meta.json files in vendor directory are unreasonably large
2 participants