-
Notifications
You must be signed in to change notification settings - Fork 5.6k
fix(check): ignore errors on ambient modules #29135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kt3k
merged 20 commits into
denoland:main
from
kt3k:fix_ignore_errors_on_ambient_modules_deno_check_2
May 16, 2025
Merged
fix(check): ignore errors on ambient modules #29135
kt3k
merged 20 commits into
denoland:main
from
kt3k:fix_ignore_errors_on_ambient_modules_deno_check_2
May 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nathanwhit
approved these changes
May 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
Only comment is that we probably need to apply this to other subcommands, depending on whether we're going to do typechecking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #27633
This PR makes
deno check
ignoreCannot find module
diagnostic if the missing module specifier matches one of ambient module pattern. (For example if there'sdeclare module "*.svg" { ... }
declaration in one of d.ts files, importing of<any>.svg
doesn't cause type error with this change. This is necessary for passing the type checking of default vite template.)LSP already implements this in #27855
closes #28455