Skip to content

fix(fmt): indent width should be ignored when formatting with use tabs set to true #29205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 8, 2025
Merged

fix(fmt): indent width should be ignored when formatting with use tabs set to true #29205

merged 5 commits into from
May 8, 2025

Conversation

LaplaceXD
Copy link
Contributor

@LaplaceXD LaplaceXD commented May 7, 2025 •
edited
Loading

fixes #29161

@CLAassistant
Copy link

CLAassistant commented May 7, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@LaplaceXD LaplaceXD mentioned this pull request May 8, 2025
Closed
@bartlomieju bartlomieju requested a review from dsherret May 8, 2025 21:14
@LaplaceXD LaplaceXD force-pushed the fix/fmt-deleting-chars-with-use-tabs branch from 40c5706 to 953efc5 Compare May 8, 2025 21:17
dsherret
dsherret approved these changes May 8, 2025
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsherret dsherret enabled auto-merge (squash) May 8, 2025 21:24
@dsherret dsherret merged commit f8615e4 into denoland:main May 8, 2025
17 checks passed
@LaplaceXD LaplaceXD deleted the fix/fmt-deleting-chars-with-use-tabs branch May 8, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees

@dsherret dsherret

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect deno fmt behavior when using tab indentation
3 participants
@LaplaceXD @CLAassistant @dsherret