Skip to content

fix(check): don't assert unique normalized specifiers #29274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

nayeemrmn
Copy link
Contributor

Fixes #29247.

Removes machinery added in #9357. That fix wasn't in effect anymore because normalizedToOriginalMap was duplicated in some refactor and one of them was dead code. And I doubt the underlying loading issue affecting Deno.emit() still exists.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn enabled auto-merge (squash) May 13, 2025 16:09
@nayeemrmn nayeemrmn merged commit 9b0707b into denoland:main May 13, 2025
18 checks passed
@nayeemrmn nayeemrmn deleted the check-non-normalized-specifier branch May 15, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: AssertionError: The different names for the same normalized specifier are specified:
3 participants