Skip to content

fix: use v8 instead of swc for explicit resource management #29282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

fix: use v8 instead of swc for explicit resource management #29282

merged 1 commit into from
May 13, 2025

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented May 13, 2025 •
edited
Loading

Upgrades to swc_ecma_parser 13 and deno_ast 0.47.

Second attempt doing this as v8 bug has been fixed.

Closes #29031

@dsherret dsherret requested a review from bartlomieju May 13, 2025 18:51
@dsherret dsherret enabled auto-merge (squash) May 13, 2025 18:51
bartlomieju
bartlomieju approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dsherret dsherret merged commit 658489e into denoland:main May 13, 2025
18 checks passed
@dsherret dsherret deleted the fix_use_v8_explicit_resource_management branch May 13, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explicit resource management still not working natively due to SWC transpilation
2 participants
@dsherret @bartlomieju