feat(cli): add --coverage flag to deno run command
#29329
+147
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli/args/flags.rs
Outdated
| .conflicts_with("inspect-wait") | ||
| .conflicts_with("inspect-brk") | ||
| .help(cstr!("Collect coverage profile data into DIR. If DIR is not specified, it uses 'coverage/'. | ||
| <p(245)>This option can also be set via the DENO_UNSTABLE_COVERAGE_DIR environment variable.")) |
There was a problem hiding this comment.
Should this be DENO_COVERAGE_DIR instead?
There was a problem hiding this comment.
I intentionally made this DENO_UNSTABLE_COVERAGE_DIR at this point to avoid causing child process generating the coverage immediately after landing this PR.
I assume we would change this to DENO_COVERAGE_DIR when we stabilize this feature (at that point the child process start generating coverage data. I think that should happen at next minor version)
kt3k
changed the title
deno run commanddeno run command
|
Discussed with @bartlomieju, and changed this to stable feature, targeting the next minor version. |
kt3k
changed the title
deno run command--coverage flag to deno run command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16440
This PR adds
--coverageflag todeno runcommand. When the flag is specified, it generates the coverage profile in the directory specified (default iscoverage). The coverage directory can also be specified from the env varDENO_COVERAGE_DIR.