fix(compile): only include used npm packages in compiled vfs #29338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, I think it should be an opt-in flag so that it works by default and maybe doesn't work with an optimization. |
dsherret
reviewed
May 16, 2025
| @@ -767,6 +791,7 @@ impl<'a> DenoCompileBinaryWriter<'a> { | |||
| // we'll flatten to remove any custom registries later | |||
| let mut packages = npm_resolver | |||
| .resolution() | |||
| .subset(reqs) | |||
There was a problem hiding this comment.
We'll need to think of something for when there's a node_modules directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19764.
Interaction w/ non-statically-analyzable paths might be problematic, maybe we flag this? Though I think we'll have that problem with most solutions involving bundling/slimming down node_modules