Skip to content

fix(coverage): pass DENO_COVERAGE_DIR env var correctly #29363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented May 19, 2025

This was missed in #28291

This PR fixes the env var set when code coverage is enabled.

This prepares for supporting coverage from child process #16440

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 4801c0e into denoland:main May 19, 2025
18 checks passed
@kt3k kt3k deleted the fix-deno-coverage-dir branch May 19, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants