Skip to content

chore: simplify node test script #29459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented May 27, 2025

This PR removes the categorization of test files from node test script.

This categorization is only used for local terminal output, and not used for creating report json file. The viewer also independently categorize tests, and that should be sufficient for it. (The categorization in local node script now seems redundant)

@kt3k kt3k requested a review from bartlomieju May 27, 2025 01:15
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kt3k kt3k merged commit d8879ee into denoland:main May 28, 2025
18 checks passed
@kt3k kt3k deleted the chore-simplify-node-test-script branch May 28, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants