refactor: remove deno_core dependency from deno_permissions #29467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
May 27, 2025
| let len = stack.len(); | ||
| for (idx, frame) in stack.into_iter().enumerate() { | ||
| writeln!( | ||
| &mut output, | ||
| "┃ {} {}", | ||
| colors::gray(if idx != len - 1 { "├─" } else { "└─" }), | ||
| colors::gray(deno_core::error::format_frame::< |
There was a problem hiding this comment.
Isn't this a functional change? We're no longer formatting the frame here
bartlomieju
reviewed
May 27, 2025
| stack | ||
| .into_iter() | ||
| .map(|frame| { | ||
| deno_core::error::format_frame::<deno_core::error::NoAnsiColors>( |
There was a problem hiding this comment.
Oh I see, it's rewritten here. Maybe add a comment in runtime/permissions/ that it's expected the frames are in readable format?
There was a problem hiding this comment.
I updated the name from GetStackFn to GetFormattedStackFn.
bartlomieju
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For making this code more usable without deno_core. Will be useful in deno_resolver.