Skip to content

feat(middlewares): add CreateJobRateLimiter middleware #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented May 12, 2025

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@yxxhero yxxhero added the documentation Improvements or additions to documentation label May 12, 2025
@yxxhero yxxhero requested a review from a team as a code owner May 12, 2025 22:44
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 252d11f into main May 13, 2025
29 checks passed
@chlins chlins deleted the feat(middlewares)--add-CreateJobRateLimiter-middleware branch May 13, 2025 02:09
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.31%. Comparing base (ff59f21) to head (16dc391).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4061      +/-   ##
==========================================
- Coverage   34.32%   34.31%   -0.01%     
==========================================
  Files         344      344              
  Lines       40334    40334              
==========================================
- Hits        13843    13841       -2     
- Misses      25571    25575       +4     
+ Partials      920      918       -2     
Flag Coverage Δ
unittests 34.31% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
manager/middlewares/ratelimiter.go 0.00% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants