ES|QL: Add support for LOOKUP JOIN on aliases #128519
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @luigidellaquila, I've created a changelog YAML for you. |
luigidellaquila
commented
May 29, 2025
| if (out.getTransportVersion().onOrAfter(TransportVersions.JOIN_ON_ALIASES)) { | ||
| out.writeString(indexPattern); | ||
| } else if (indexPattern.equals(shardId.getIndexName()) == false) { | ||
| throw new EsqlIllegalArgumentException("Aliases and index patterns are not allowed for LOOKUP JOIN []", indexPattern); |
There was a problem hiding this comment.
Should we throw an exception here?
The alternative is to just allow to execute the JOIN on the remote node based on the index name (rather than the alias name), that means different security constraints and no alias filters.
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
luigidellaquila
commented
May 29, 2025
| @@ -521,7 +553,7 @@ abstract static class TransportRequest extends AbstractTransportRequest implemen | |||
|
|
|||
| @Override | |||
| public final String[] indices() { | |||
| return new String[] { shardId.getIndexName() }; | |||
| return new String[] { indexPattern }; | |||
There was a problem hiding this comment.
This is the real fix to the Security aspects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for LOOKUP JOIN on aliases: