Count and Count distinct functions for tsds #128530
Conversation
elasticsearchmachine
added
the
needs:triage
dnhatn
added
:StorageEngine/TSDB
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
| @FunctionInfo(returnType = { "integer", "long" }, description = "The count over time value of a field.", type = FunctionType.AGGREGATE) | ||
| public CountOverTime( | ||
| Source source, | ||
| @Param(name = "field", type = { "aggregate_metric_double", "double", "integer", "long" }) Expression field |
There was a problem hiding this comment.
I think this method supports more types rather than these. Can you copy the list from the count function?
|
|
||
| @Override | ||
| public CountDistinct perTimeSeriesAggregation() { | ||
| // TODO(pabloem): Do we need to take in a precision parameter here? |
| description = "The count of distinct values over time for a field.", | ||
| type = FunctionType.AGGREGATE | ||
| ) | ||
| public DistinctOverTime( |
There was a problem hiding this comment.
Should we call it CountDistinctOverTime? I'm okay with DistinctOverTime, but I prefer to keep it consistent with count_distinct.
| ) | ||
| public DistinctOverTime( | ||
| Source source, | ||
| @Param(name = "field", type = { "aggregate_metric_double", "double", "integer", "long", "float" }) Expression field |
There was a problem hiding this comment.
Same here, I think this function supports more than these types. Can you copy the list from count_distinct?
| CountOverTime::new | ||
| ); | ||
|
|
||
| @FunctionInfo(returnType = { "integer", "long" }, description = "The count over time value of a field.", type = FunctionType.AGGREGATE) |
There was a problem hiding this comment.
In what scenario does this return integer? The returnType and dataType() for Count appears to only return longs
| ); | ||
|
|
||
| @FunctionInfo( | ||
| returnType = { "integer", "long" }, |
There was a problem hiding this comment.
Same question as before about when does this return integers?
PTAL @dnhatn ? : )
LMK if you have any questions!