Handle quotes in gradle arguments #128548
Conversation
idegtiarenko
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
| @@ -41,4 +41,4 @@ else | |||
| fi | |||
|
|
|||
| set -e | |||
| $GRADLEW -S --max-workers=$MAX_WORKERS $@ | |||
| $GRADLEW -S --max-workers=$MAX_WORKERS "$@" | |||
There was a problem hiding this comment.
Please let me know if additional testing (besides main pipeline) is required for this change
There was a problem hiding this comment.
Seems reasonable to me. Have you tested running the pipeline that caused this issue to verify it fixes your problem?
There was a problem hiding this comment.
LGTM. have you manually triggered the pipeline that failed from the patch branch to verify the fix works here too?
| @@ -41,4 +41,4 @@ else | |||
| fi | |||
|
|
|||
| set -e | |||
| $GRADLEW -S --max-workers=$MAX_WORKERS $@ | |||
| $GRADLEW -S --max-workers=$MAX_WORKERS "$@" | |||
There was a problem hiding this comment.
LGTM. have you manually triggered the pipeline that failed from the patch branch to verify the fix works here too?
| @@ -1,7 +1,7 @@ | |||
| steps: | |||
| - label: periodic-micro-benchmarks | |||
| command: | | |||
| .ci/scripts/run-gradle.sh -p benchmarks/ run --args 'org.elasticsearch.benchmark._nightly -rf json -rff build/result.json' | |||
| .ci/scripts/run-gradle.sh :benchmarks:run --args 'org.elasticsearch.benchmark._nightly -rf json -rff build/result.json' | |||
|
I've asked @brianseeders to have a look at this too as his bash foo is beyond mine and he authored that initially i think |
When executing
.ci/scripts/run-gradle.sh -p benchmarks/ run --args 'org.elasticsearch.benchmark._nightly -rf json -rff build/result.json'I was getting following error:I believe this is happening due to quotes in the command. unlike
$@,"$@"should preserve quotes.