Skip to content

Fix unfavorable logger name uvicorn.error #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

tejaschauhan369
Copy link

Summary

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Kludex
Copy link
Member

Kludex commented May 11, 2025

That's not the way to move forward on this. It will break a lot of projects.

@Kludex Kludex closed this May 11, 2025
@tejaschauhan36912
Copy link

Hey Marcelo,
Please suggest the correct way, I want to contribute

@Kludex
Copy link
Member

Kludex commented May 23, 2025

The thing is, if we merge this, there will be a lot of people complaining because I broke everybody's logging setup.

We need a way to move towards this idea in a way that doesn't break people's code. I think the idea is to move towards v1, and then on v2 change this.

@tejaschauhan36912
Copy link

tejaschauhan36912 commented May 24, 2025

FYI: I haven't removed the existing logger "uvicorn.error" code diff,
I've added a new logger "uvicorn.log" and used it,
Do you still think it will break?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants