Skip to content

Apply get_client_addr formatting to WebSocket logging #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

Harry-Lees
Copy link
Contributor

Summary

Update address formatting in websocket logging. Previously, the incoming address for websockets was logged as follows:

INFO:     ('127.0.0.1', 55200) - "WebSocket /test" [accepted]

This PR updates the logging to match other HTTP methods.

INFO:     127.0.0.1:55315 - "WebSocket /test" [accepted]

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Kludex Kludex merged commit fa3d9d2 into encode:master May 14, 2025
16 checks passed
@Kludex
Copy link
Member

Kludex commented May 14, 2025

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants