fix(model-core) apiVersion for core k8s resources #6941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HasMetadata#getApiVersion method is returning a string starting with "/" when the group is "". This is not consistent with how owner references are specified. This issues is causing: operator-framework/java-operator-sdk#2723
mnk
requested review from
manusa,
oscerd,
rohanKanojia and
shawkins
as code owners
rohanKanojia
approved these changes
Mar 11, 2025
|
Weird, I would have thought that this was covered already… 🤔 |
|
Unified how api version is dealt with. |
|
manusa
added a commit
that referenced
this pull request
Mar 12, 2025
Signed-off-by: Marc Nuri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The HasMetadata#getApiVersion method is returning a string starting with "/" when the group is "".
This is not consistent with how owner references are specified.
This issues is causing:
operator-framework/java-operator-sdk#2723
Type of change
test, version modification, documentation, etc.)
Checklist