Properly load lazy HTML elements before taking screenshots. #1601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the issue queue there's several suggestions about how to lazy load images. However they are all a bit lacking. They still require adding
delay
orpostInteractionWait
to wait for the images to load. To do it right we need a promise.Here's a draft PR that does it marginally better. But images aren't the only thing that can be lazy. I haven't tested this code on lazy iframes (and the variables should be renamed to indicate that).
I'm also not a JS engineer (is it obvious). So this might be improved even more.