Skip to content

fix: handle null title gracefully #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joshjohanning
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our contribution guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This fixes a bug - I noticed with a colleague's blog that for whatever reason, had some null titles. XML: https://pascoal.net/index.xml

We were seeing errors in the workflow:

Error: https://pascoal.net/index.xml runner failed, please verify the configuration. Error:
Error: Cannot read response->item->title

Just gracefully handling the error so that the run can succeed.

After the fix, there are no issues:

Logs:

https://pascoal.net/index.xml runner succeeded. Post count: 80
  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Other information:

@gautamkrishnar
Copy link
Owner

gautamkrishnar commented Mar 29, 2025

@joshjohanning thanks a lot for contributing. LGTM 👍🏻

@gautamkrishnar gautamkrishnar merged commit b93a8fa into gautamkrishnar:master Mar 29, 2025
1 of 2 checks passed
@gautamkrishnar
Copy link
Owner

@all-contributors please add @joshjohanning for code

Copy link
Contributor

@gautamkrishnar

I've put up a pull request to add @joshjohanning! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants