Skip to content

Fix $file::changeTemplate() #6739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2025
Merged

Fix $file::changeTemplate() #6739

merged 1 commit into from
Feb 11, 2025

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Oct 14, 2024 •
edited by bastianallgeier
Loading

Description

Summary of changes

  • Ensure that file template always gets written to and read from default language content file

Changelog

Fixes

  • Fixed file template wrongfully being written to secondary language content file

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added this to the 4.5.0 milestone Oct 14, 2024
@distantnative distantnative self-assigned this Oct 14, 2024
@distantnative distantnative force-pushed the fix/file-change-template branch from 2757fe4 to 11fbc6e Compare October 15, 2024 13:43
@distantnative distantnative marked this pull request as ready for review October 15, 2024 14:41
@distantnative distantnative marked this pull request as draft October 15, 2024 14:44
distantnative
distantnative commented Oct 15, 2024
View reviewed changes
@bastianallgeier bastianallgeier modified the milestones: 4.5.0, 4.6.0 Nov 12, 2024
@distantnative distantnative modified the milestones: 4.6.0, 4.7.0 Jan 17, 2025
@distantnative distantnative force-pushed the fix/file-change-template branch 2 times, most recently from 2801d77 to e9bddb1 Compare February 10, 2025 16:51
@distantnative distantnative marked this pull request as ready for review February 10, 2025 16:53
@bastianallgeier bastianallgeier merged commit 7a50107 into develop-minor Feb 11, 2025
3 checks passed
@bastianallgeier bastianallgeier deleted the fix/file-change-template branch February 11, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
critical: roadblock 🚧 Needs to be solved first
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier