Skip to content

Language variables dialog with entries field #7173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Apr 29, 2025

Description

Summary of changes

  • Language variable dialog uses entries field
Screenshot 2025-04-29 at 17 54 21 Screenshot 2025-04-29 at 17 54 27 Screenshot 2025-04-29 at 17 54 38 Screenshot 2025-04-29 at 17 54 33 - Fixed immutable bug in `LanguageVariable::create()`

Additional context

Changelog

Feature

  • Language variables with multiple translation strings (for different counts) can now be edited in the Panel using the new entries field

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative marked this pull request as ready for review April 29, 2025 20:04
@distantnative distantnative requested a review from a team April 29, 2025 20:04
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great. It would of course be nice, if we could add the index number (0, 1, 2+) as help text somehow to each entry. But I think it's understandable enough for now.

I agree about the test coverage. Do we want to actively ignore it code comments or simply merge it?

@distantnative
Copy link
Member Author

I would just merge it.

@bastianallgeier bastianallgeier merged commit 3caf590 into v5/develop Apr 30, 2025
11 of 12 checks passed
@bastianallgeier bastianallgeier deleted the v5/enhancement/language-variable-dialog-entries branch April 30, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants