Skip to content

Enhanced Preview Buttons and Preview View #7220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 15, 2025

Conversation

bastianallgeier
Copy link
Member

@bastianallgeier bastianallgeier commented May 14, 2025

Description

This PR refactors the new Preview View in order to clean up the UX and simplify how to preview pages.

Changelog

Enhancement

  • New git-branch icon

Enhancements from previous betas

  • The PreviewView component and backend code has been radically simplified and its UX has been improved. You can now switch between versions and languages easily.
  • The old open button is back in each model view and a new preview button has been added.

Breaking changes from previous betas

  • The PreviewButton class now uses preview as icon and Preview as text.
  • All model views now use the new OpenButton instead of the PreviewButton and the refactored PreviewButton in addition to that.
  • The PreviewDropdownButton has been removed

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@bastianallgeier bastianallgeier force-pushed the v5/enhancement/simplified-previews branch from d4dee84 to 9bc2448 Compare May 14, 2025 15:28
@bastianallgeier bastianallgeier requested a review from a team May 14, 2025 15:29
@bastianallgeier bastianallgeier added this to the 5.0.0-rc.1 milestone May 14, 2025
Copy link
Member

@lukasbestle lukasbestle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I like:

  • Displaying the form buttons depending on the active preview makes a lot of sense.
  • It's definitely simpler than the previous UI.

What I don't quite like:

  • Having the version selector as a dropdown feels a bit cumbersome. Two clicks are needed to switch between changes and latest.
  • Somehow I miss the side-by-side view as I wrote on Discord already.

Suggestion:

Maybe the version selector could be a button group with:

Latest | Layout columns icon | Changes

Then one could easily switch between the versions and with the middle button use the side-by-side view. Then we would no longer need all those previous buttons to shrink/expand the individual preview panes but the side-by-side preview would still survive. This of course only works as long as there are only ever two versions (latest and changes), but we will need and want to redesign the view later again anyway. This simple control would IMO make the new changes feature easier to understand and use in 5.0.

@bastianallgeier bastianallgeier requested review from lukasbestle and a team May 15, 2025 10:02
@bastianallgeier bastianallgeier force-pushed the v5/enhancement/simplified-previews branch from 0c0f0fd to 3689832 Compare May 15, 2025 10:36
@bastianallgeier bastianallgeier merged commit b07bf37 into v5/develop May 15, 2025
14 checks passed
@bastianallgeier bastianallgeier deleted the v5/enhancement/simplified-previews branch May 15, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants