-
-
Notifications
You must be signed in to change notification settings - Fork 177
Enhanced Preview Buttons and Preview View #7220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced Preview Buttons and Preview View #7220
Conversation
d4dee84
to
9bc2448
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I like:
- Displaying the form buttons depending on the active preview makes a lot of sense.
- It's definitely simpler than the previous UI.
What I don't quite like:
- Having the version selector as a dropdown feels a bit cumbersome. Two clicks are needed to switch between changes and latest.
- Somehow I miss the side-by-side view as I wrote on Discord already.
Suggestion:
Maybe the version selector could be a button group with:
Latest | Layout columns icon | Changes
Then one could easily switch between the versions and with the middle button use the side-by-side view. Then we would no longer need all those previous buttons to shrink/expand the individual preview panes but the side-by-side preview would still survive. This of course only works as long as there are only ever two versions (latest and changes), but we will need and want to redesign the view later again anyway. This simple control would IMO make the new changes feature easier to understand and use in 5.0.
0c0f0fd
to
3689832
Compare
Description
This PR refactors the new Preview View in order to clean up the UX and simplify how to preview pages.
Changelog
Enhancement
git-branch
iconEnhancements from previous betas
Breaking changes from previous betas
preview
as icon andPreview
as text.Ready?
For review team