Skip to content

Include name of repo in cleanup log entries #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Torbjorn-Svensson
Copy link

Contributed by STMicroelectronics

Contributed by STMicroelectronics

Signed-off-by: Torbjörn SVENSSON <[email protected]>
@Torbjorn-Svensson Torbjorn-Svensson requested a review from a team as a code owner August 23, 2024 18:16
Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for swinging by.

I'm curious--what is your use case where this would be helpful?

@Torbjorn-Svensson
Copy link
Author

It would have been very helpful when debugging the issue that I reported in dependabot/dependabot-core#10493.

@jeffwidman, if you have any idea what can be done about that issue, I would be happy to help out with both coding it and validating the change if needed. It's really frustrating to spend 15 min on each dependabot check to just pull the same image over and over again (yes I could work around it by tagging it manually, but that's only going to work for a short time and then it's out of date again).

@jeffwidman
Copy link
Member

Looking at this again, sorry it's been so long.

When you say "for repo", is that a git repo? Or some other type of package repo? Can you give me an example of what you're expecting this to log?

Because if it's git repos, it should just be our standard repos unless you're running a fork... and in that case I'd expect a user to be aware that they're running a fork... so I'm still a little puzzled how this helped you in debugging.

But I also haven't looked deeply at this code, so I'm probably misunderstanding something.

@Torbjorn-Svensson
Copy link
Author

My memory is also flushed on this topic, but from what I do remember, the repo here is not the github repository, but rather the image repository. I.e., instead of a hash, it would also show what docker image that the hash belongs to.

With current implementation, the following can be seen in the log:

Cleaning up images for ghcr.io/dependabot/dependabot-updater-bundler
Cleaning up images for ghcr.io/dependabot/dependabot-updater-cargo
Cleaning up images for ghcr.io/dependabot/dependabot-updater-composer
Cleaning up images for ghcr.io/dependabot/dependabot-updater-pub
Cleaning up images for ghcr.io/dependabot/dependabot-updater-docker
Cleaning up images for ghcr.io/dependabot/dependabot-updater-elm
Cleaning up images for ghcr.io/dependabot/dependabot-updater-github-actions
Cleaning up images for ghcr.io/dependabot/dependabot-updater-gitsubmodule
Cleaning up images for ghcr.io/dependabot/dependabot-updater-gomod
Cleaning up images for ghcr.io/dependabot/dependabot-updater-gradle
Cleaning up images for ghcr.io/dependabot/dependabot-updater-maven
Cleaning up images for ghcr.io/dependabot/dependabot-updater-mix
Cleaning up images for ghcr.io/dependabot/dependabot-updater-nuget
Cleaning up images for ghcr.io/dependabot/dependabot-updater-npm
Cleaning up images for ghcr.io/dependabot/dependabot-updater-pip
Cleaning up images for ghcr.io/dependabot/dependabot-updater-swift
Cleaning up images for ghcr.io/dependabot/dependabot-updater-terraform
Cleaning up images for ghcr.io/dependabot/dependabot-updater-devcontainers
Cleaning up images for ghcr.io/dependabot/dependabot-updater-dotnet-sdk
Cleaning up images for ghcr.io/dependabot/dependabot-updater-bun
Cleaning up images for ghcr.io/dependabot/dependabot-updater-docker-compose
Cleaning up images for ghcr.io/dependabot/dependabot-updater-uv
Cleaning up images for ghcr.io/dependabot/dependabot-updater-helm
Cleaning up images for ghcr.io/github/dependabot-update-job-proxy/dependabot-update-job-proxy
Skipping current image sha256:e853b5fe83d27be63e5024c940b1ef5eae269ebf8320b31989fa1788d4456d84
Removing image sha256:6f1278af8e3bd9e430a3035d771c3be2e689d40ffd5c718c5f932239f599db2a
Removing image sha256:085264fb7f3c9946b24adaabe6723a3f2fbbc5363324c621b7b632142337e503

With my change, I expect that the last 2 lines would have change to something like:

Skipping current image sha256:e853b5fe83d27be63e5024c940b1ef5eae269ebf8320b31989fa1788d4456d84 for ghcr.io/github/dependabot-update-job-proxy/dependabot-update-job-proxy
Removing image sha256:6f1278af8e3bd9e430a3035d771c3be2e689d40ffd5c718c5f932239f599db2a for ghcr.io/dependabot/dependabot-updater-npm
Removing image sha256:085264fb7f3c9946b24adaabe6723a3f2fbbc5363324c621b7b632142337e503 for ghcr.io/dependabot/dependabot-updater-cargo

(I have not checked what the hashes belongs to, so just take the above snippet as an example output and not literal.)

I hope this makes more sense to you now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants