-
Notifications
You must be signed in to change notification settings - Fork 51
Include name of repo in cleanup log entries #1293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Include name of repo in cleanup log entries #1293
Conversation
Contributed by STMicroelectronics Signed-off-by: Torbjörn SVENSSON <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for swinging by.
I'm curious--what is your use case where this would be helpful?
It would have been very helpful when debugging the issue that I reported in dependabot/dependabot-core#10493. @jeffwidman, if you have any idea what can be done about that issue, I would be happy to help out with both coding it and validating the change if needed. It's really frustrating to spend 15 min on each dependabot check to just pull the same image over and over again (yes I could work around it by tagging it manually, but that's only going to work for a short time and then it's out of date again). |
Looking at this again, sorry it's been so long. When you say "for repo", is that a git repo? Or some other type of package repo? Can you give me an example of what you're expecting this to log? Because if it's git repos, it should just be our standard repos unless you're running a fork... and in that case I'd expect a user to be aware that they're running a fork... so I'm still a little puzzled how this helped you in debugging. But I also haven't looked deeply at this code, so I'm probably misunderstanding something. |
My memory is also flushed on this topic, but from what I do remember, the With current implementation, the following can be seen in the log:
With my change, I expect that the last 2 lines would have change to something like:
(I have not checked what the hashes belongs to, so just take the above snippet as an example output and not literal.) I hope this makes more sense to you now. |
Contributed by STMicroelectronics