Skip to content

Block editor plugin is broken with multiple import errors #10822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
benbowler opened this issue May 26, 2025 · 2 comments
Closed
2 tasks

Block editor plugin is broken with multiple import errors #10822

benbowler opened this issue May 26, 2025 · 2 comments
Labels
P0 High priority Team M Issues for Squad 2 Type: Bug Something isn't working

Comments

@benbowler
Copy link
Collaborator

benbowler commented May 26, 2025

Bug Description

The RRM Block editor plugin and SiwG blocks fail to load with a number of errors relating to imports:

Uncaught TypeError: Cannot read properties of undefined (reading 'Chip')
Uncaught (in promise) TypeError: Cannot read properties of null (reading 'getSettings')

Steps to reproduce

  1. Checkout develop.
  2. Enable the feature flag, connect the RRM Module with a publication
  3. Load a post in the block editor, see the error in the console

I tested this on main and it still works there so it looks like a possible bug introduced by recent Webpack updates or something else.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The Reader Revenue Manager post-level settings in the block editor should load as expected.
  • The Reader Revenue Manager blocks in the block editor should load as expected.
  • Reader Revenue Manager should not cause any errors in the browser console within the block editor.

Implementation Brief

  • Add googlesitekit-components as a dependency for Reader Revenue Manager scripts enqueued to the block editor that also have googlesitekit-modules-reader-revenue-manager as a dependency.
  • Review and merge Fix block editor error caused by RRM #10828, which already covers the above point.

Test Coverage

  • No tests need to be added/updated.

QA Brief

  • Follow the "Steps to reproduce" and verify that the issue no longer appears.

Changelog entry

  • Fix error preventing the Reader Revenue Manager block editor plugin and Sign in With Google blocks from loading in the block editor.
@benbowler benbowler added Type: Bug Something isn't working P0 High priority labels May 26, 2025
@benbowler benbowler changed the title RRM block editor broken with multiple import errors Block editor plugin is broken with multiple import errors May 26, 2025
@ivonac4 ivonac4 added the Team M Issues for Squad 2 label May 26, 2025
@nfmohit nfmohit self-assigned this May 26, 2025
@nfmohit nfmohit removed their assignment May 27, 2025
@techanvil techanvil self-assigned this May 27, 2025
@techanvil
Copy link
Collaborator

IB ✅

@techanvil techanvil assigned techanvil and unassigned techanvil May 27, 2025
techanvil added a commit that referenced this issue May 27, 2025
Fix block editor error caused by RRM
@techanvil techanvil removed their assignment May 27, 2025
@kelvinballoo kelvinballoo self-assigned this May 27, 2025
@kelvinballoo
Copy link
Collaborator

QA Update ✅

Tested this and the error reported was not surfaced.
Testing involved:

  • Testing on post and page
  • Testing with blocks SiwG and RRM on the post/page
  • Tested saving of different setting for RRM at the page/post level

Video is attached for reference.

10822.test.ok.2.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 High priority Team M Issues for Squad 2 Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants