[BUG] graphite-web 1.1.8+ dependency on pyparsing misses version requirement #2834
Labels
Comments
|
That's bug in dependencies, indeed. 1.1.8 is not latest, though, will check if happens on latest code |
deniszh
added a commit
to deniszh/graphite-web
that referenced
this issue
Aug 25, 2024
deniszh
added a commit
that referenced
this issue
Aug 25, 2024
* Adding django-upgrade pre-commit * Submitting django upgrade result * Include test suite in release (fixing #2830) * Fix pyparsing dep version (fixing #2834) * Upgrade Django and python version in reqs and tox * adding dependabot * adding new python in tests * Comment out broken tests * fix attime tests for python 3.12 * fix more tests for python 3.12 * simplify tox * fix self.assertRegex test * fix self.assertRegex test * fix self.assertEquals test * pleasing linter * more pleasing linter * trying to fix events test * let's keep doc on py310 * more event test fixes * moving doc to 3.10 * ok, moving back
You're correct. The new requirement / missing dependency happened at version 1.1.8, but even the latest docs and Thanks for taking a look at the issue. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Deniszh's commit should be applied, it addresses the issue. |
|
@timmooney : it was applied in #2846 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm attempting to update a working install of whisper/carbon/graphite-web from 1.1.5 to current latest. Once I'm on a more recent version, I'll be moving my install to a newer system & Python3, but for now I have to get the current version upgraded.
My working install with 1.1.5 is using
pyparsing 2.2.0.I've discovered that graphite-web 1.1.8 and 1.1.10 will not work with that version of pyparsing. At 1.1.8
webapp/graphite/render/grammar.pygoes away and is replaced bywebapp/graphite/render/grammar_unsafe.py.The new
grammar_unsafe.pystill usespyparsing, but its import now also requirespyparsing_unicode.pyparsing_unicodewas introduced inpyparsingversion 2.3.0. See: pyparsing CHANGESIt looks like the
requirements.txtfile was updated to note the dependency (for pip, I assume?), but other places were not.Two things should be updated:
pyparsing >= 2.3.0. Currently other python module dependencies are mentioned, but pyparsing isn't listed at all.check_dependencies.pyscript is checking for any version ofpyparsingand isn't detecting an installed version that predatespyparsing_unicode.I'm not wise in the ways of Python, but it's possible the
tox.inialso may need updates?The text was updated successfully, but these errors were encountered: