Allow Riff-Raff to update both Applications ASGs during GuCDK migration #27979
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmockett
force-pushed
the
jm/applications-riff-raff-dual-stack
branch
from
36e13cf to
0cd7b33
Compare
DanielCliftonGuardian
approved these changes
May 20, 2025
jamesmockett
force-pushed
the
jm/applications-riff-raff-dual-stack
branch
2 times, most recently
from
e675652 to
d8b8f17
Compare
jamesmockett
force-pushed
the
jm/applications-riff-raff-dual-stack
branch
from
d8b8f17 to
36d6299
Compare
|
Overdue on FRONTS-PROD, ADMIN-PROD (merged by @jamesmockett 30 minutes and 7 seconds ago) What's gone wrong? |
|
Seen on ADMIN-PROD (merged by @jamesmockett 34 minutes and 31 seconds ago)
|
Continuous deployment is temporarily disabled as this needs to be manually deployed in a specific order (along with corresponding Platform updates) to CODE and PROD. |
|
Seen on FRONTS-PROD (merged by @jamesmockett 37 minutes and 47 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
We are dual-stacking Applications as we migrate it to GuCDK. This means all infrastructure components (load balancer, autoscaling group, instances etc.) are temporarily duplicated.
Riff-Raff normally expects to find exactly one matching autoscaling group for a set of tags. When deploying it will update the application code for that autoscaling group only. If Riff-Raff finds more than one autoscaling group with the same set of tags the deployment will fail.
This change adds the
asgMigrationInProgressto allow Riff-Raff to update both Applications autoscaling groups when deploying.This relies on https://github.com/guardian/platform/pull/1847 being applied first.
Checklist
Validated with Riff-Raff