Skip to content

[VAULT-35715] UI: Namespace picker is updated after add/delete namespace #30737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

beagins
Copy link
Contributor

@beagins beagins commented May 23, 2025

Description

What does this PR do?

  • Namespace picker list is updated after add/delete namespace on the manage namespace page w/o manual refresh
  • Enterprise tests passing ✅

    267 tests completed in 154279 milliseconds, with 0 failed, 10 skipped, and 0 todo.
    1541 assertions of 1541 passed, 0 failed.

delete-me-demo.mov

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 23, 2025
@beagins beagins added the ui label May 23, 2025
@beagins beagins added this to the 1.20.0-rc milestone May 23, 2025
Copy link

github-actions bot commented May 23, 2025

CI Results:
All Go tests succeeded! ✅

@beagins beagins force-pushed the ui/VAULT-35715/refresh-after-delete branch from 54156c8 to ae06982 Compare May 23, 2025 15:48
await settled();
}
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed and moved to helpers/commands.js

@beagins beagins marked this pull request as ready for review May 30, 2025 00:04
@beagins beagins requested review from a team as code owners May 30, 2025 00:04
@beagins beagins requested a review from cinthiaconti May 30, 2025 00:04
@beagins beagins force-pushed the ui/VAULT-35715/refresh-after-delete branch from f082daf to 4789479 Compare May 30, 2025 00:04
Copy link

github-actions bot commented May 30, 2025

Build Results:
All builds succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant