Skip to content

identity: use request context namespace for entity merges #30744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mpalmi
Copy link
Contributor

@mpalmi mpalmi commented May 23, 2025

Description

This PR fixes an error made in a previous PR (https://github.com/hashicorp/vault-enterprise/pull/7770), wherein we force the request context to match the namespace of the entity being merged. Consequently, a namespace check which should have failed would pass (specifically for entity merges). This PR reverts that change and introduces a test which would have caught the error.

Enterprise PR: https://github.com/hashicorp/vault-enterprise/pull/8145

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@mpalmi mpalmi added this to the 1.19.5 milestone May 23, 2025
@mpalmi mpalmi requested a review from davidadeleon May 23, 2025 18:22
@mpalmi mpalmi requested a review from a team as a code owner May 23, 2025 18:22
@mpalmi mpalmi changed the title Identity/fix entity ns identity: use request context namespace for entity merges May 23, 2025
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 23, 2025
Copy link

github-actions bot commented May 23, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented May 23, 2025

Build Results:
All builds succeeded! ✅

@mpalmi mpalmi requested a review from miagilepner May 23, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.19.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants