Skip to content

server: fix action sync websocket test #10730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

emmanuel-ferdman
Copy link

Description

Resolved duplicate test function names in the websocket action test suite by renaming conflicting test cases to maintain clear distinction between success and failure scenarios.

Changelog

Component: server
Type: bugfix
Product: community-edition

Short Changelog

Fixed test naming conflicts in action test suite.

Long Changelog

  • Identified and resolved duplicate test function names
  • Ensured proper naming conventions for success/failure test variants
  • Maintained existing test coverage while improving test clarity

Related Issues

Solution and Design

  • Analyzed test suite for naming conflicts
  • Applied consistent naming pattern to distinguish test cases
  • Verified no impact on test functionality

Steps to test and verify

  1. Execute the full test suite
  2. Verify all test cases run independently
  3. Confirm test output shows proper case differentiation

Limitations, known bugs & workarounds

None - this change only affects test naming.

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No

Metadata

Does this PR add a new Metadata feature?

  • No

GraphQL

  • No new GraphQL schema is generated

Breaking changes

  • No Breaking changes

@emmanuel-ferdman emmanuel-ferdman requested a review from a team as a code owner May 11, 2025 15:20
@CLAassistant
Copy link

CLAassistant commented May 11, 2025

CLA assistant check
All committers have signed the CLA.

@emmanuel-ferdman
Copy link
Author

@Varun-Choudhary @rohankmr414 could you please review this small PR when you get the chance? thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants