fix qwen_2_5_vl video processing #6868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JJJYmmm Hi, have you tested the effect of this implementation? In SFT stage? |
Not yet, I just refer the solution of official repo. |
This was referenced Feb 11, 2025
1587causalai
pushed a commit
to 1587causalai/llama_factory
that referenced
this pull request
Feb 18, 2025
* fix qwen_2_5_vl video processing * Update mm_plugin.py * Update mm_plugin.py --------- Co-authored-by: hoshi-hiyouga <[email protected]>
This was referenced Feb 19, 2025
stephen-nju
pushed a commit
to stephen-nju/Llmtrain
that referenced
this pull request
Mar 24, 2025
* fix qwen_2_5_vl video processing * Update mm_plugin.py * Update mm_plugin.py --------- Co-authored-by: hoshi-hiyouga <[email protected]> Former-commit-id: 9153a7b
yoonseok312
pushed a commit
to pensieve-ai/LLaMA-Factory-vlm
that referenced
this pull request
Apr 29, 2025
* fix qwen_2_5_vl video processing * Update mm_plugin.py * Update mm_plugin.py --------- Co-authored-by: hoshi-hiyouga <[email protected]> Former-commit-id: 9153a7b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6860
Calculate the actual fps for each video and get correct
second_per_grid_tsThe origin solution directly use
video_fps, this may be incorrect when meeting long video.The modified version works on my project.
Before submitting