Skip to content

fix: more z-index issue #18598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2025
Merged

fix: more z-index issue #18598

merged 2 commits into from
May 25, 2025

Conversation

alextran1502
Copy link
Contributor

@alextran1502 alextran1502 commented May 25, 2025

  • Search suggestion box
  • Video/LivePhotos play icon

Fixes #18575

@alextran1502 alextran1502 changed the title search bar z issue fix: more z-index issue May 25, 2025
@alextran1502
Copy link
Contributor Author

@danieldietzler Still haven't found the cause of the modal anchor to the top page instead of the viewport yet. Might need to look into the UI library.

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like it, but I don't have a lot of time currently to look into fixing it properly. I am fine with merging this as-is; I can later revisit z-indices again and clean up more of this.

@alextran1502 alextran1502 merged commit 4743a08 into main May 25, 2025
56 of 58 checks passed
@alextran1502 alextran1502 deleted the search-bar-z-issue branch May 25, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video play icons overlap search popup
2 participants