chore: Refactor Edit Album Modal #18653
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's more where that's coming from! |
| const handleEdit = async (album: AlbumResponseDto) => { | ||
| await modalManager.show(EditAlbumForm, { | ||
| album, | ||
| onEditSuccess: successEditAlbumInfo, |
There was a problem hiding this comment.
Just looked at this again and you should get rid of onEditSuccess. EditAlbumForm should have an onClose(album?: ...) => void; if album is provided it was a success, otherwise it was cancelled. That's how we treat those generally now
danieldietzler
approved these changes
May 28, 2025
| }); | ||
| if (editedAlbum) { | ||
| successEditAlbumInfo(editedAlbum); | ||
| } | ||
| closeAlbumContextMenu(); |
There was a problem hiding this comment.
Do you want to close the context menu before the modal is opened? That's how it was before. (kind of, because before the operation before wasn't blocking)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored EditAlbumModal to use the new modalManager