-
Notifications
You must be signed in to change notification settings - Fork 13.5k
feat(input-otp): add new input-otp component #30386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature-8.6
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you, @brandyscarney, for your work on this component. One feature suggestion: pressing CTRL+A (or CMD+A on macOS) inside the component could select and clear all input fields at once. This would align with common input behavior and improve UX for users needing to re-enter their code quickly. Example: https://input-otp.rodz.dev/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found with core and Angular. I'm waiting on React and Vue to be ready for review.
packages/angular/test/build.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these changes needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the change to rsync
because creating the Vue test app was ridiculously slow for me, but I can revert it for now since it actually caused CI to fail.
docs/component-guide.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊
Issue number: internal
What is the current behavior?
In order to re-create an OTP Input component users have to custom style an
<ion-input>
, possibly multiple, to get the design and functionality they want.What is the new behavior?
ion-input-otp
which provides the OTP input functionalitytype
which determines whether the boxes accept numbers or text/numbers and determines the keyboard to displayinputmode
propertylength
property to control the number of input boxesfill
,shape
,size
,color
separators
property to show a separator between 1 or more input boxesdisabled
,readonly
and invalid statespattern
propertyionInput
,ionChange
,ionComplete
,ionBlur
,ionFocus
reset
,setFocus
Does this introduce a breaking change?
Other information
Dev build:
8.5.7-dev.11748379940.12698faf
Previews
Documentation