Skip to content

Add RawInputListenerAdapter for easier listener creation #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

capdevon
Copy link
Contributor

Implement RawInputListenerAdapter to provide default empty implementations for all listener methods.

@MeFisto94
Copy link
Member

LGTM, the only gripe I have is with the constructor: Do we even explicitly need one? I guess for abstract classes it may implicitly be protected? Also the javadoc on it is kind of "old school" java, not really providing any additional value. (compare "javadoc: getter function for foo, that gets the variable foo" 😄 )

@capdevon
Copy link
Contributor Author

capdevon commented Dec 29, 2024

You're correct that abstract classes have an implicit protected constructor by default.
We can remove the explicit constructor declaration to avoid redundancy.

I utilized AI to assist in the rapid generation of the initial Javadoc, which helped me quickly establish a baseline and avoid common grammatical errors :)

@yaRnMcDonuts yaRnMcDonuts added this to the v3.8.0 milestone Feb 11, 2025
@yaRnMcDonuts
Copy link
Member

I plan to merge this PR in 24 hours.

@yaRnMcDonuts yaRnMcDonuts merged commit 713df22 into jMonkeyEngine:master Feb 17, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants