Fix comic page sorting by including natural path and filename order, Fixing #6642 #6904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
terokorp
force-pushed
the
cbz-page-sorting-fix
branch
from
834f345 to
92c8852
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
terokorp
force-pushed
the
cbz-page-sorting-fix
branch
from
92c8852 to
d79ce5a
Compare
terokorp
force-pushed
the
cbz-page-sorting-fix
branch
from
d79ce5a to
ac55f29
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, folder names (i.e. file paths) were ignored during sorting, which caused pages from different chapters or volumes to be mixed together. Additionally, lexicographic filename sorting caused issues such as "Vol. 12 Ch. 56" appearing before "Vol. 1 Ch. 1".
Changes:
file.pathandfile.name, using a natural sort algorithm.Ch. 4.5.Issues
Fixes #6642