[JENKINS-64708] Deprecate PageObject constructor receiving the Injector as parameter

[akash-manna-sky]

JENKINS-64708

Now,

1. The deprecated constructor now has a clearer warning message
2. The new helper constructor makes it easier to migrate existing code to use contexts correctly
3. The factory method provides a convenient migration path for existing code

Testing done

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[akash-manna-sky]

Hello @fcojfernandez,
could you please give me a quick initial review ? And please let me know if anything needs fixing or improving.

Thanks!

[uhafner]

When you set an element to deprecated you should ensure that you are not using it in your own code base.

The code migration is not clear to me: All my page objects use this constructor right now. If I remember correctly, this was required to create these page objects dynamically. Is this still possible then?

[akash-manna-sky]

Hi @uhafner,
I make few changes.
Could you please suggest if there's an alternative approach for dynamic creation under the new changes? A bit more guidance on the recommended migration path would be really helpful.

Thanks!

[uhafner]

Hi @uhafner, I make few changes. Could you please suggest if there's an alternative approach for dynamic creation under the new changes? A bit more guidance on the recommended migration path would be really helpful.

Thanks!

I have no idea. Since you are trying to mark the constructor as deprecated I thought that you know what to do for all those plugins that use it right now. Why are you fixing this specific issue then? Or did you pick an arbitrary issue that you want to solve?

Maybe it is best to set the issue as in progress in Jira, assign your name in Jira as well and ask in Jira what should be done for those plugins that use the constructor right now. Hopefully, the author of the issue responds and tells you what to do instead.

It would be also helpful to remove the usages of this constructor in the acceptance harness. Then you will see if your proposed changes break something...

[uhafner]

BTW: when you are rebasing your code then it makes sense to squash the commits to a single one.

[jtnord]

that will make the Jenkins Page object interesting....

[akash-manna-sky]

Hello @jtnord, I didn't quite get that. How do I proceed from here?
Should I try removing the references of the constructor and then see if anything breaks (like @uhafner mentioned) or there is a different approach to it?

[jtnord]

Hello @jtnord, I didn't quite get that.
What would you pass as the context for the Jenkins PageObject (

acceptance-test-harness/src/main/java/org/jenkinsci/test/acceptance/po/Jenkins.java

Line 70 in 7358513

this(injector, startAndGetUrl(controller));

)

But what is the problem with the constructor with the Injector? what issue are you trying to solve here?

[akash-manna-sky]

Hello @basil Could you give me a quick review on how to proceed further?

Thanks!

[basil]

What problem is this PR trying to solve? The linked Jira ticket does not clearly describe the problem or why this task is a solution for it.